Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests back to the development-v6 container #1396

Merged
merged 5 commits into from Jul 26, 2023
Merged

Conversation

PromoFaux
Copy link
Member

@PromoFaux PromoFaux commented Jul 23, 2023

What does this PR aim to accomplish?:

I neglected to look at the tests when I first started playing with the v6 image. This PR makes a few adjustments to the test process and removes a lot of tests/functions that we (probably) no longer need.

Starting the test suite with a couple of simple ones.

PRs will now only run the tests - rather than the build/merge/deploy stages which are now separated out to another yaml file

To run the tests locally, just run ./build-and-test.sh in the repo root


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux PromoFaux force-pushed the v6/tests branch 2 times, most recently from 94d68b2 to e0bbcb4 Compare July 23, 2023 22:58
@PromoFaux PromoFaux marked this pull request as draft July 23, 2023 23:02
@PromoFaux PromoFaux force-pushed the v6/tests branch 2 times, most recently from 2974f1f to f751fde Compare July 24, 2023 17:06
- Tweak build-and-test.sh to allow tests to run against more platforms using buildx
- Split GHA out into two seperate files. One for tests on pull requests, another for build and merge on push to `development-v6` (add other branches in later)

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
… example has not been used in a long time) , begin building test library from ground up.

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
…than copying in, buildx would not work the other way.

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
…parently

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
…d, change command to sh instead of bash

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@PromoFaux PromoFaux changed the title [tmp] test Add tests back to the development-v6 container Jul 24, 2023
@PromoFaux PromoFaux requested a review from a team July 24, 2023 17:50
@PromoFaux PromoFaux marked this pull request as ready for review July 24, 2023 17:51
@PromoFaux PromoFaux linked an issue Jul 24, 2023 that may be closed by this pull request
@PromoFaux PromoFaux merged commit 6065425 into development-v6 Jul 26, 2023
9 checks passed
@PromoFaux PromoFaux deleted the v6/tests branch July 26, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Do/Redo tests
1 participant