Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to ropensci style #7

Open
bomeara opened this issue Jan 17, 2018 · 2 comments
Open

Convert to ropensci style #7

bomeara opened this issue Jan 17, 2018 · 2 comments

Comments

@bomeara
Copy link
Member

bomeara commented Jan 17, 2018

We seem to have a mix of styles: Google's R style guide and some other style. We should convert all to use ropensci's style: https://github.com/ropensci/onboarding/blob/master/packaging_guide.md. They'd be a good home for rphylotastic, folks are used to their style and their domain, and it's been battle-tested.

@bomeara
Copy link
Member Author

bomeara commented Jan 17, 2018

@bomeara
Copy link
Member Author

bomeara commented Jan 17, 2018

I've done most of this now. We need to play a bit with the species list functions -- the first parameter tends to be user id, but should probably rewrite that to have it cached somewhere and just pass in the thing we want to change (i..e, the species to change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant