Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support APNG #108

Closed
CasperHK opened this issue Mar 17, 2017 · 5 comments
Closed

Support APNG #108

CasperHK opened this issue Mar 17, 2017 · 5 comments
Milestone

Comments

@CasperHK
Copy link

Will peer support APNG in the future version?

@ghost
Copy link

ghost commented Mar 17, 2017

@CasperHK i agree with you.that's more like it .

@phw
Copy link
Owner

phw commented Mar 17, 2017

I thought about this, too, when reading that Chrome 59 will add support APNG. Not 100% sure yet, as this would require different tools (both imagemagick and ffmpeg do not handle APNG). Have to investigate a bit more. But I actually would like to support it, as it fits well into what Peek is doing.

Also see my comment on #89 (comment) for some more information on APNG and WebP. But the point about browser support will change if Chrome jumps in and support it. For MS Edge it is at least under review: https://wpdev.uservoice.com/forums/257854-microsoft-edge-developer/suggestions/6513393-apng-animated-png-images-support-firefox-and-sa

@phw phw added this to the 1.2.0 milestone Oct 12, 2017
@phw
Copy link
Owner

phw commented Oct 12, 2017

I just learned that ffmpeg can generate apng. Not quite sure since when this was available, the official documentation also does not mention the APNG muxer, but it exists (https://trac.ffmpeg.org/wiki/SponsoringPrograms/GSoC/2015#AnimatedPortableNetworkGraphicsAPNG). And with my current changes to use ffmpeg also for GIF this becomes quite trivial to add, so expect this in the next release :D

Same is true for WebP by the way, although I tried it and was not happy with the quality produced.

phw added a commit that referenced this issue Oct 12, 2017
@phw
Copy link
Owner

phw commented Oct 12, 2017

I implemented this, just needs some testing in different distributions and updating of the custom ffmpeg builds for app packages.

But it is working great for me here locally.

phw added a commit that referenced this issue Oct 13, 2017
phw added a commit that referenced this issue Oct 13, 2017
@phw
Copy link
Owner

phw commented Nov 6, 2017

Working well in master branch. I would welcome some testing and feedback, but for now I think this is working fine.

@phw phw closed this as completed Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants