Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status variables documentation links to dev.mysql.com are invalid #19069

Open
M393 opened this issue Mar 20, 2024 · 11 comments
Open

Status variables documentation links to dev.mysql.com are invalid #19069

M393 opened this issue Mar 20, 2024 · 11 comments
Assignees
Labels
affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) affects/6.0 This issue or pull-request affects 6.0.x releases (and maybe further versions) Bug A problem or regression with an existing feature waiting on upstream Issues blocked by a third-party

Comments

@M393
Copy link
Contributor

M393 commented Mar 20, 2024

Describe the bug

In Status -> Variables clicking the blue question mark icon links to https://dev.mysql.com/doc/refman/5.7/en/open-tables.html
The link should be https://dev.mysql.com/doc/refman/5.7/en/server-status-variables.html#statvar_Open_tables

To Reproduce

Steps to reproduce the behavior:

  1. Go to Status -> All status variables
  2. Click on the question mark in the column Variable
  3. See error

Expected behavior

Documentation links should be to the correct page.

Screenshots

image

Server configuration

  • Database version: MySQL 5.7.44
  • phpMyAdmin version: 5.2.2-dev+20240309.aaf7188717
@williamdes
Copy link
Member

@williamdes williamdes self-assigned this Mar 20, 2024
@williamdes williamdes added Bug A problem or regression with an existing feature waiting on upstream Issues blocked by a third-party affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) affects/6.0 This issue or pull-request affects 6.0.x releases (and maybe further versions) labels Mar 20, 2024
@M393
Copy link
Contributor Author

M393 commented Mar 20, 2024

williamdes/mariadb-mysql-kbs#300 is for MariaDB and they are working, just with additional redirects.

My links are to dev.mysql.com and no link I tried works. I guess MySQL changed their links, so it should be updated in phpMyAdmin.

@williamdes
Copy link
Member

williamdes/mariadb-mysql-kbs#300 is for MariaDB and they are working, just with additional redirects.

My links are to dev.mysql.com and no link I tried works. I guess MySQL changed their links, so it should be updated in phpMyAdmin.

Hey,
This is my library, it is used for the generation of this link you are reporting.
I think the variable is not yet detected by my library

@M393
Copy link
Contributor Author

M393 commented Mar 21, 2024

All links for status variables I tested are broken. Also Open_tables exists in the file you linked:
image

@williamdes
Copy link
Member

Okay, thanks for this info. I may have missed something. I will test on MySQL 5.7 and fix this

@williamdes
Copy link
Member

williamdes commented Mar 24, 2024

All links for status variables I tested are broken. Also Open_tables exists in the file you linked:

Seems like they exist but only for MariaDB. So the links are not available on MySQL.
I implemented it for MySQL, I hope this will be okay: williamdes/mariadb-mysql-kbs@0b2a6ad
New data: williamdes/mariadb-mysql-kbs#342

PS: How to you have such variables, Com_xxx stuff is not showing in my list ?

@M393
Copy link
Contributor Author

M393 commented Mar 24, 2024

Looks like all status variables starting with com_ should link here.
See the status variable reference.

Thanks for working on this so quickly. I tested it and the link to Open_tables now takes me to the correct location.
Though it links to the MySQL 8.0 kb, not 5.7 (not sure if this is intentional or an oversight).

@williamdes
Copy link
Member

Thank you for confirming, do you know how you did activate the Com_xxx variables?
On my end here is the list of variables I need to add williamdes/mariadb-mysql-kbs#343

Unfortunately the library does not handle different versions of MySQL in the way where it would send you to the version you are using. It has no knowledge of versions. Only variables.

Did you install the composer dev version?
Or replace with the download of my library in your vendor folder?
Let me know

@M393
Copy link
Contributor Author

M393 commented Mar 25, 2024

I did not do anything to enable these variables, it is just a standard installation of MySQL 5.7.

I change this in composer.json

-        "williamdes/mariadb-mysql-kbs": "^1.2"
+        "williamdes/mariadb-mysql-kbs": "dev-main"

@williamdes
Copy link
Member

I did not do anything to enable these variables, it is just a standard installation of MySQL 5.7.

Okay, on the Docker version I do not see them :/

@M393
Copy link
Contributor Author

M393 commented Mar 25, 2024

They are available on the demo server if this helps you:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) affects/6.0 This issue or pull-request affects 6.0.x releases (and maybe further versions) Bug A problem or regression with an existing feature waiting on upstream Issues blocked by a third-party
Projects
None yet
Development

No branches or pull requests

2 participants