Allow to omit semi-colon before PHP close tag #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylekatarnls
changed the title
kylekatarnls
changed the title
kylekatarnls
force-pushed
the
fix/optional-semi-colon-before-php-end-tag
branch
2 times, most recently
from
cef6688
to
cb6071a
Compare
AJenbo
previously approved these changes
Aug 17, 2022
kylekatarnls
force-pushed
the
fix/optional-semi-colon-before-php-end-tag
branch
from
cb6071a
to
fea46dc
Compare
|
How do we progress with this? Still wanting to merge into 2.x or going 3.x (probably by re-doing it)? The milestone was set to 3.0.0 back in 2021, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
Issue: Fix phpmd/phpmd#892
Breaking change: no