-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPMD Take some time to response - with FileResource PHP Deprecated #1057
Comments
How long is it taking?
Sounds like the issue is with how homebrew is packaging phpmd, maybe contact them regarding the warning |
Hi, How long is it taking? What hardware are you using? What is less time? |
Installing whith homebrew, you get the PHAR build which is a single build that needs to run everywhere whatever is the PHP version, so you get an old version of symfony/config in it for backward-compatibility reason and this old version uses methods that are deprecated in 8.3. There is no possible fix for that, it will de facto be solved when dropping old versions on next major version. Composer installation does not have this pitfall as it will install the more recent version of symfony/component compatible with your PHP version. |
@kylekatarnls Thank You for explanation. That's make senes. |
See source code embeddedd into PHPMD PHAR version : https://github.com/symfony/config/blob/2.8/Resource/FileResource.php Explains is given on PHP documentation : https://www.php.net/manual/en/class.serializable This problem was solved since Symfony 4.3 ( see symfony/config@b8f4eae ) Symfony 4.3 did not support PHP 5.3 until 7.0. |
It will until next major version |
Current Behavior
im running phpmd via sublime linter and command line with
phpmd -vvv SomeController.php text phpmd.xml
it's return warning and take time around 6s (im on macbook m2)
PHP Deprecated: Symfony\Component\Config\Resource\FileResource implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in phar:///opt/homebrew/Cellar/phpmd/2.15.0/bin/phpmd/vendor/symfony/config/Resource/FileResource.php on line 21
Here is code im testing with
Expected Behavior
Should take less time without warning
Steps To Reproduce:
Checks before submitting
The text was updated successfully, but these errors were encountered: