Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

where to put the xhp php7 repo #1

Open
firodj opened this issue Nov 7, 2016 · 1 comment
Open

where to put the xhp php7 repo #1

firodj opened this issue Nov 7, 2016 · 1 comment

Comments

@firodj
Copy link

firodj commented Nov 7, 2016

hi @sgolemon , We are at KMK-ONLINE (KMKlabs) already use XHP on HHVM and want that XHP feature to be enabled on PHP7. So that at that time we didnt find if there is a work for PHP7 version, becuase the github Fork graph didnot include this phplang/xhp repo. Please review our forked repo at https://github.com/KMK-ONLINE/xhp-php7-extension and if it is possible to PR our works to this phplang/xhp for community. Thanks

@pprkut
Copy link

pprkut commented Jun 2, 2017

I think a good first step would be to figure out the differences between the two. Reviewing the entire repo as a whole is a bit too big of a task I fear, so if you could split it up into incremental improvements and open pull requests for each, I doubt it's not getting looked at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants