Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues regarding changelog #97

Open
jonashauge opened this issue Oct 7, 2015 · 6 comments
Open

Issues regarding changelog #97

jonashauge opened this issue Oct 7, 2015 · 6 comments

Comments

@jonashauge
Copy link
Contributor

Hi Miha,

a couple of issues regarding the changelog feature;

  1. When entries (eg. a subnet or an IP address) is deleted, then the entire changelog for the object is removed as well.The content in the changelog should be kept - otherwise the log is useless for auditing purposes :-)
  2. changelog is not done for VLANs, l2-domains, devices or vrf's which are just as crucial as subnets, sections and ip addresses.

In a perfect world, changelog should also be done on nameservers and firewallzones, but the 4 points in 2) are the most important ones.

/Jonas

@phpipam
Copy link
Owner

phpipam commented Oct 8, 2015

Hi, Well changelog is actually there, it is just not picked up by the query, as id of original object is not available anymore. Dont know how to change that.

Will add for other objects aswell.

@jonashauge
Copy link
Contributor Author

Hmm, my best suggestion will be to add an extra column (cObjectName?) in the changelog table where you record the subnet/ip of 'cid' as a varchar. Then if 'cid' is gone as the ip/subnet was deleted, then print the value of the new column in italic (and no link). Then the current functionality is kept and changes with deletion will be shown. If someone can think of a better solution, feel free to comment :-)

Another finding regarding changelog. If you edit an object and push the edit button without changing any value, then an empty changelog i written. As no change has been done, I would suggest to skip writing anything to the changelog.

@michielvisser
Copy link
Contributor

+1 for the suggestion of @jonashauge as this seems the best solution. One of my clients is working with Infoblox IPAM and there you can always trace who for example deleted a subnet. The changelog in there is pure text and not relying on any other information in the database as far as I can see.

For auditing a changelog that has no relational information (entries made as pure text at the time of the changes) would be a big plus.

@Park0
Copy link

Park0 commented Jul 13, 2017

I am missing changelog for subnets as well. You would make me happy if this could be in 1.4. It's related in a way to #800.

@xFRaNeRx
Copy link

+1. This log will be very usefull for us too.

@Anyone9060
Copy link

I noticed this too. And to track who deleted a subnet, I had to check the main log file. Click the wrench "Show Tools Menu" > under "Tools" > "Log Files".

Here you can download the logs in xls format and find who may have deleted a subnet. I've recently run into the 65536 row limit in excel so this feature is also lacking now. Perhaps xlsx can be used as the export format?

I just brought it up today in issue: ChangeLog viewing and row limits #4092

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants