Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom display through default slot no longer works with Vue 3 #41

Open
AndreasNasman opened this issue Jan 8, 2021 · 5 comments
Open

Comments

@AndreasNasman
Copy link

Hi!

I'm using a similar implementation of he-tree-vue as shown here:
https://he-tree-vue.phphe.com/guide.html#custom-display-through-default-slot

The example above breaks when adding it to a Vue 3 project since slot-scope is no longer available.
https://vuejs.org/v2/guide/components-slots.html#Deprecated-Syntax

I want to migrate my code to Vue 3, but I'm unsure how to refactor slot-scope with he-tree-vue. Could you update the documentation to reflect this change?

Thanks!
– Andreas

@phphe
Copy link
Owner

phphe commented Jan 9, 2021

change slot-scope to v-slot should work

@AndreasNasman
Copy link
Author

It also needs to be moved up to the Tree component. Having docs compatible with Vue 3 would be beneficial in cases like this. 🙂

@cbloss
Copy link

cbloss commented Sep 29, 2023

I know this is VERY old but @AndreasNasman was that all you had to do was change it to v-slot and to the tree level?

@AndreasNasman
Copy link
Author

Sorry @cbloss , I don't remember anymore! I should have posted a working example; I try to do it in all my comments but forgot on this one of course. 🙈

@cbloss
Copy link

cbloss commented Sep 30, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants