Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify PHIVE install GPG keys #3694

Closed
fulldecent opened this issue Apr 10, 2024 · 4 comments
Closed

Specify PHIVE install GPG keys #3694

fulldecent opened this issue Apr 10, 2024 · 4 comments

Comments

@fulldecent
Copy link
Contributor

fulldecent commented Apr 10, 2024

Currently documentation here recommends to install using PHIVE:

1. Using phive (recommended)

And our recommended command is:

`$ phive install phpDocumentor`

PHIVE supports to specify a GPG for security:

https://github.com/phar-io/phive/blob/10e5602f8d8c964bf48bb5c369da8e131c0ab5ae/src/commands/help/help.md?plain=1#L30-L31

I suppose that always using that --trust-gpg-keys is best practice. So this issue is to update our documented PHIVE recommended install invocation to include the --trust-gpg-keys argument.

And this may require signing the releases of phpDocumentator, whould should be a good thing.

@phpdoc-bot phpdoc-bot added this to Needs triage in phpDoc issue triage board Apr 10, 2024
@jaapio
Copy link
Member

jaapio commented Apr 10, 2024

We do ship php documentor with a signature: https://github.com/phpDocumentor/phpDocumentor/releases/tag/v3.4.3 but it has been to long ago for me to remember exactly how this was done :-(

Besides that since the moment we wrote about phive, I also created: https://github.com/phpDocumentor/shim
which is a composer package using the signature to verify the downloaded phar. Maybe this helps you a bit?

@fulldecent
Copy link
Contributor Author

Thank you. I have gotten it to install with this key:

8AC0BAA79732DD42

Source: https://github.com/fulldecent/phpdoc/actions/runs/8652882245/workflow#L70

Is that official or a MITM key?

@jaapio
Copy link
Member

jaapio commented Apr 12, 2024

Yes, you can find our public key here: https://keys.openpgp.org/search?q=info%40phpdoc.org

or fetch it with gpg --recv-key 8AC0BAA79732DD42 This will add the key to your trusted keys to phive can validate.

@fulldecent
Copy link
Contributor Author

Thank you, got it.

Added improved install instruction at #3699

@jaapio jaapio closed this as completed in f74a645 May 8, 2024
jaapio added a commit that referenced this issue May 8, 2024
Add gpg key to install instruction, fixes #3694
phpDoc issue triage board automation moved this from Needs triage to Closed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants