Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background colour is not defined, but text colour is #3679

Closed
DanielSiepmann opened this issue Mar 7, 2024 · 0 comments · Fixed by #3680
Closed

Background colour is not defined, but text colour is #3679

DanielSiepmann opened this issue Mar 7, 2024 · 0 comments · Fixed by #3680
Projects
phpDoc issue triage board

Comments

@DanielSiepmann
Copy link
Contributor

Expected behavior

Visiting rendered docs should be readable, also if the default colours of the browser were adjusted.

Actual behavior

The css defines a text colour, but no background colour. That will break depending on default background colour defined within the browser.

Steps to reproduce the problem

  1. Change default background colour of your browser to something dark
  2. Visit rendered documentation with default theme

Your environment

The actual website at https://docs.phpdoc.org/guide/getting-started/installing.html#installation and any rendered documentation with downloaded phar file.

image

I'll prepare a PR.
@phpdoc-bot phpdoc-bot added this to Needs triage in phpDoc issue triage board Mar 7, 2024
DanielSiepmann added a commit to DanielSiepmann/fork-phpDocumentor that referenced this issue Mar 7, 2024
@DanielSiepmann
Add CSS background colour for body
2ad19c5 
As text is defined, but background was not.
Most developers assume every browser has the same default colors, e.g.
white for background.
But actually users can alter those colors, and only changing one color
will end up in a hard to read result.

Therefore the background color is now explicitly set to the expected
white defaults.

Resolves phpDocumentor#3679
@DanielSiepmann DanielSiepmann mentioned this issue Mar 7, 2024
Merged
phpDoc issue triage board automation moved this from Needs triage to Closed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
phpDoc issue triage board
  
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CSS background colour for body DanielSiepmann/fork-phpDocumentor
1 participant
@DanielSiepmann