Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider inotify as a replacement for manual/polling scans of folders #201

Open
bish0polis opened this issue Feb 21, 2021 · 4 comments · May be fixed by #792
Open

consider inotify as a replacement for manual/polling scans of folders #201

bish0polis opened this issue Feb 21, 2021 · 4 comments · May be fixed by #792
Labels
scanner Related to the scanner component

Comments

@bish0polis
Copy link
Contributor

Near the end of src/docs/usage-nextcloud.md, for instance, it advises the reader to configure a periodic scanner to check for changes to a folder.

Have you considered using inotify? Setting up inotify will eliminate the need for cronned scans or manual scanning.

Low-priority, but maybe consider it?
@viktorstrate
Copy link
Member

It's currently not supported but it would be a nice addition.
I'll transfer the issue to the main repository.

@viktorstrate viktorstrate transferred this issue from photoview/photoview.github.io Feb 21, 2021
@viktorstrate viktorstrate added the scanner Related to the scanner component label Feb 21, 2021
@gomme600
Copy link

gomme600 commented Jul 7, 2021

Hi, any updates on this ? I have just installed photoview and I'm not sure what a good interval would be ? I would like photos to appear fast. Is 1 minute too fast ? I have set 1 hour at the moment ? Thanks

@viktorstrate
Copy link
Member

viktorstrate commented Jul 7, 2021 •
edited

I have quite a few bug fixes and improvements that I want to work on before this one but I really think this would be a great addition. If someone wants to work on this it'd be a big help.

The scanner uses quite a lot of CPU resources when scanning for changed files, even if there are no new changes, as it will look up every photo in the database to check if it has been scanned before. I wouldn't recommend an interval below an hour especially for larger libraries.

But give the issue a 👍 I sort after that when prioritising issues.

@Phlogi
Copy link
Contributor

Phlogi commented Aug 3, 2022 •
edited

Is there a way to trigger the scanner with a cli or curl call? I have a bash script solution with inotify that watches a folder and could trigger the scanner appropriately.

#671

@viktorstrate viktorstrate mentioned this issue Aug 31, 2022
Closed
@amit-handa amit-handa linked a pull request Jan 26, 2023 that will close this issue
Draft
@viktorstrate viktorstrate linked a pull request Feb 8, 2023 that will close this issue
reactively update the library + exif data #792
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scanner Related to the scanner component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reactively update the library + exif data amit-handa/photoview
4 participants
@viktorstrate @Phlogi @bish0polis @gomme600