Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored point clouds #38

Open
carlosmccosta opened this issue Oct 21, 2019 · 0 comments
Open

Colored point clouds #38

carlosmccosta opened this issue Oct 21, 2019 · 0 comments

Comments

@carlosmccosta
Copy link
Contributor

carlosmccosta commented Oct 21, 2019

Please consider publishing point clouds with the color / grayscale information.
Most if not all 3D cameras that have this information publish it alongside the 3D point data.
This is trivial to implement on the phoxi_camera and is much user friendly to the end users than forcing them to subscribe to a image and xyz point cloud.
The end users should not have to deal with the particular technology of a 3D sensor.
For PhotoNeo, the correspondence between a 3D point and its gray pixel is direct, but for other types of 3D sensing it might not be trivial to do or might be proprietary and not available to the end users.
As such, this should be done on the camera driver and not by the end users (most end users want to have the ability to change the 3D sensor without having to change their 3D perception implementation).

Please take a look at my fork, I have already implemented this feature:
https://github.com/carlosmccosta/phoxi_camera/commits/master-all-pr
#21
#24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant