Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changePage() assumes prefix-free page names #286

Open
cbettinger opened this issue Apr 3, 2018 · 0 comments
Open

changePage() assumes prefix-free page names #286

cbettinger opened this issue Apr 3, 2018 · 0 comments
Labels

Comments

@cbettinger
Copy link

Calling phonon.navigator().changePage(pageName) does not do anything if pageName is a prefix of phonon.navigator().currentPage.

The following conditions prevents unnecessary changes from the current page to the current page, but it prevents changes to other pages with the current page name as a prefix, too.

if(window.location.hash.indexOf(hash) === -1 && opts.useHash) {
   window.location.hash = hash;
}
@qathom qathom added the v1 label Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants