Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about the partition of training and validation sets #76

Open
string-ellipses opened this issue Mar 1, 2024 · 1 comment
Open

about the partition of training and validation sets #76

string-ellipses opened this issue Mar 1, 2024 · 1 comment

Comments

@string-ellipses
Copy link

string-ellipses commented Mar 1, 2024

I am confused about the division of training and validation sets, because I see "self.val_data = self.train_data ” in experiment.py (line 184), which seems to cause the training set and validation set to not be separatedd, thus affecting a fair evaluation of model performance.
1851842d77f50ef37c30c163a505003

perhaps there are steps in other sections to separate the training and validation sets?

@phizaz
Copy link
Owner

phizaz commented Mar 2, 2024

Validation in generative models is done a bit differently. For example, FID calculation takes 50k images to get a reasonably stable result. If all of the 50k images are set aside for validation, there will be only 20k images left for training which is impractical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants