New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deregister Runner Application when Spot Interruption signal is received #804
Comments
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions. |
Any news regarding this? |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions. |
bump |
Hi Do you have any thoughts on how you might see this working? |
Hi @ScottGuymer , yeah, one idea would be to install a cron inside the runners that checks regularly for spot interruption notices (see https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/spot-instance-termination-notices.html), then it would deregister itself from the available pool of runners, or via a lambda that would be delegated to perform this action. Ideally it would wait until a job is finished, if it currently runs one. Of course it would be difficult to predict when a certain job is expected to finish, so it would be enough to wait for a reasonable amount of time (which would be before the end of the termination timestamp that was given by the notice) so that a job has more chances on finishing. These would hopefully minimize the runners being shut down while running a job. |
When I understand this correctly part of this module could be a connection to the SNS topic and listen for these events. And then shutdown the runner using the normal shutdown runner. |
In PR #3789 we adding a first step to handle spot termination events. |
to prevent issues like this: #84
The text was updated successfully, but these errors were encountered: