Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash Discord #7

Open
NhProGamer opened this issue Mar 25, 2023 · 22 comments
Open

Crash Discord #7

NhProGamer opened this issue Mar 25, 2023 · 22 comments

Comments

@NhProGamer
Copy link

This plugin totaly crash discord on load

@NhProGamer
Copy link
Author

NhProGamer commented Mar 25, 2023

Okayy, the problem comes from Betterdiscord, just install it with the manual method
--> https://docs.betterdiscord.app/users/getting-started/installation/#manual-installation

@philhk
Copy link
Owner

philhk commented Mar 26, 2023

I've noticed it with recent versions of Discord as well. I haven't looked that deeply into the issue because I'm trying to port the plugin and submit it to Vencord anyway. If I'm successful I'll update the repo. Thanks for the solution👍.

@Pickymarker
Copy link

same with me on discord stable

@EndlessVoidDev
Copy link

image
Discord_ZcK28NWMK3

crash when choosing screen

@Pickymarker
Copy link

Pickymarker commented Apr 6, 2023

exactly the same for me i want to use this over YABDP4Nitro but this happens good i at least have that as a backup even though this plugin way superior to YABDP4Nitro the main reason i use custom resolution and stuff is to get the best quality bitrate resolution no lag ever almost 1080p or 1080p 120fps or 63fps full screen with audio screenshare combined with obs window projector with application audio capture

@philhk
Copy link
Owner

philhk commented Apr 6, 2023

Hey, too bad the plugin doesn't work anymore. I made a plugin for Vencord that does exactly what this plugin does, but better. Unfortunately the plugin hasn't been merged yet, but I'm hoping that will be the case in the next few days or weeks, as the repository owner has many other PRs to check, so I'll have to wait. Here is a link to my fork. You can build it yourself with this guide and then use my plugin. I probably wont update this repository anymore.

@Pickymarker
Copy link

the crash still happens on the latest better discord and i want a better discord version still because there are plugins vencord does not have that stop me from switching over

@jupelost
Copy link

jupelost commented Apr 13, 2023

Hey, too bad the plugin doesn't work anymore. I made a plugin for Vencord that does exactly what this plugin does, but better. Unfortunately the plugin hasn't been merged yet, but I'm hoping that will be the case in the next few days or weeks, as the repository owner has many other PRs to check, so I'll have to wait. Here is a link to my fork. You can build it yourself with this guide and then use my plugin. I probably wont update this repository anymore.

I tried building your fork however it doesn't seem to be working i checked discord settings as well to see if the vencord section was there and it seems like it isnt injecting vencord at all

@aceyx3
Copy link

aceyx3 commented Apr 13, 2023

Same for me. Same problem as jupelost.

@philhk
Copy link
Owner

philhk commented Apr 13, 2023

That's weird. When you run "pnpm inject" does a new window appear? If not, can you send me the logs of the terminal.

@aceyx3
Copy link

aceyx3 commented Apr 13, 2023

It does show the installation window after I run the pnpm inject. Though after patching, nothing appears in the settings menu.

@philhk
Copy link
Owner

philhk commented Apr 13, 2023

image
When you click this button do you get an error? If so you need to close Discord before clicking Install.

@jupelost
Copy link

jupelost commented Apr 13, 2023

NfPNvrWvG1.mp4

maybe im missing something?

@aceyx3
Copy link

aceyx3 commented Apr 13, 2023

maybe im missing something?

Same for me.

@philhk
Copy link
Owner

philhk commented Apr 13, 2023

Ok, I found the issue, it was a problem with my plugin. Just type "git pull" in the command line (if you don't have git just download the repository again) then reinstall with "pnpm inject" and it should work.

@jupelost
Copy link

Beautiful, it worked!

@philhk
Copy link
Owner

philhk commented Apr 13, 2023

Great! Thanks for helping me find the bug.

@aceyx3
Copy link

aceyx3 commented Apr 13, 2023

Ok, I found the issue, it was a problem with my plugin. Just type "git pull" in the command line (if you don't have git just download the repository again) then reinstall with "pnpm inject" and it should work.

When should I type git pull? After I clone the repo?

@philhk
Copy link
Owner

philhk commented Apr 13, 2023

You don't have to clone again, you can just use "git pull", it's updating the old version you currently have, but you can also clone the whole repo again if you want.

@aceyx3
Copy link

aceyx3 commented Apr 13, 2023

Thank you so much! Works flawlessly, cheers!

@jupelost
Copy link

jupelost commented Jul 7, 2023

literally doing gods work hope it becomes an official plugin soon :)!

@LavenderAndChamomile
Copy link

image Discord_ZcK28NWMK3

crash when choosing screen

Same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants