Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to customize short-form/long-form detction of S-H algorithm #24

Open
gopalkalpande opened this issue Jun 9, 2020 · 2 comments

Comments

@gopalkalpande
Copy link

gopalkalpande commented Jun 9, 2020

image

image

@sidhantls
Copy link

That is the result of the Schwartz-Hearst algorithm itself. After detecting the two d's at the end and start of Derived, it extracts that.

If you expect more such cases, update the logic in select_definition to only match short-form char with long-form when it's at the start of a word L247

if short_char == long_char:
)

@philgooch
Copy link
Owner

Hi @gopalkalpande @sid-sundrani thanks for this. This is an open-source project, so if you can submit a pull-request with a fix and accompanying unit test, that will be very welcome.

@micahjsmith micahjsmith changed the title Not extracting the full form correctly Ability to customize short-form/long-form detction of S-H algorithm Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants