Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot disable for Google Slides #3254

Closed
everyonesdesign opened this issue Feb 24, 2019 · 7 comments · Fixed by #4402
Closed

Cannot disable for Google Slides #3254

everyonesdesign opened this issue Feb 24, 2019 · 7 comments · Fixed by #4402

Comments

@everyonesdesign
Copy link

I prefer to disable Vimium for Google Products because they have decent keyboard navigation by themselves; but I fail to do so when I edit Google Slides.

When I try to disable it, it gives current URL as "about:blank" and it still works after I try to block it.

image

It seems that it switches to some iframe, because there're a few iframes with such a URL.

Is it a known issue? How can I overcome this?

@gdh1995
Copy link
Contributor

gdh1995 commented Feb 24, 2019

Currently, you can add another rule with a pattern of "https://docs.google.com" to also disable Vimium on the main (topest) frame.

As far as the "about:blank"

Um, this is a new issue that I didn't expect. I think Vimium needs to re-think about its exclusion logic: it should also be disabled on such iframes, obeying what it is on the parent/top frame.

@victortrac
Copy link

This has been driving me crazy for a few days.

@gdh1995
Copy link
Contributor

gdh1995 commented Mar 14, 2019

I've released a new version of modified Vimium (I call it Vimium C), and it applies rules from a top frame to such about:blank frames. You may have a try.

Link to download: https://chrome.google.com/webstore/detail/vimium-c/hfjbmagddngcpeloejdejnfgbamkjaeg or https://github.com/gdh1995/vimium-c/releases .

@srsudar
Copy link

srsudar commented Mar 14, 2021

@gdh1995 , do you have any pointers to how you got rules from a top frame applying to about:blank frames? I looked through your changelog and tried searching the repo for about:blank but didn't see anything immediately obvious.

@gdh1995
Copy link
Contributor

gdh1995 commented Mar 14, 2021

Vimium C checks URLs which don't look like *://* and turns to apply passkeys of their top frames in:
https://github.com/gdh1995/vimium-c/blob/7e4672cd80ab59ba130e127edde116a6c136640e/background/exclusions.ts#L62-L67

@binlaniua
Copy link

any update?

@tralph3
Copy link

tralph3 commented Feb 14, 2022

Still an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants