-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javascript bookmarks not working anymore #3178
Comments
I use javascript bookmarklets all the time from the vomnibox and have really been missing them over the last little while. Here's to hoping the great minds can figure it out. |
+1 here. Chrome V70 works, V71 fails. My javascript is (case-sensitive Find): |
+1 to it not working on Chrome V71. Scriptlet works if I copy directly into the console or manually click. |
Been running into the same problem lately. Seems to have started being an issue only a couple days ago. |
Since `chrome.tabs.update()` no longer supports `javascript:` URLs, here we inject them into the page itself. Replaces philc#3167. Replaces philc#3209. Fixes philc#3178.
looks like there is a fix. any chance this will be merged/released soon? |
Guys, this is still not working?(( |
Still not working in 76.0.3809.100. Very frustrating. You have to click on another bookmark first then it works. See also: https://support.google.com/chrome/thread/3959468?hl=en |
Still does not work on |
Guys, if there is a fix, why don't you merge it? This thing drives me nuts( I've got a couple of great js-bookmarks, that help me automate my work, and this feature could boost my productivity a lot... |
Dahan thanks for the bump and the PR. I'll merge it this weekend!
…On Sun, Nov 24, 2019 at 7:41 PM, Dahan Gong < ***@***.*** > wrote:
@ philc ( https://github.com/philc ) Could you merge #3437 (
#3437 ) to fix this issue? I've tested
it and it works well.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub (
#3178?email_source=notifications&email_token=AAACDFUW76NG5GPQYXHRRP3QVNCNHA5CNFSM4GBRMUDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFA75IA#issuecomment-557973152
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AAACDFXXB2SLPVKEKK6NPWTQVNCNHANCNFSM4GBRMUDA
).
|
It doesn't look like it was merged, or am I missing something? Thanks guys! |
Sorry for the delay folks. I've merged the fix from @gdh1995 but haven't released a new version to the chrome store. I'll batch a few more changes together in the next week and create a new release. |
My javascript bookmark use to work on Chrome 69, but it doesn't on version 71.0.3578.30.
Its content is:
javascript:(function()%7B(function () %7Bvar i%2C elements %3D document.querySelectorAll('body *')%3Bfor (i %3D 0%3B i < elements.length%3B i%2B%2B) %7Bif (getComputedStyle(elements%5Bi%5D).position %3D%3D%3D 'fixed'||getComputedStyle(elements%5Bi%5D).position %3D%3D%3D 'sticky') %7Belements%5Bi%5D.parentNode.removeChild(elements%5Bi%5D)%3B%7D%7D%7D)()%7D)()
#3167 might solve this.
The text was updated successfully, but these errors were encountered: