Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox 57: Toolbar panel not shown correctly in overflow menu #2678

Open
bartlibert opened this issue Sep 28, 2017 · 4 comments
Open

Firefox 57: Toolbar panel not shown correctly in overflow menu #2678

bartlibert opened this issue Sep 28, 2017 · 4 comments

Comments

@bartlibert
Copy link

When the vimium toolbar button is put in the new overflow menu on firefox 57, the popup is not usable, due to the height and width being too small. I'm not a 100% sure if this should be entirely fixed in the extension, but from what I gather here, it might be necessary to do some changes.

screenshot from 2017-09-28 10-04-55

@smblott-github
Copy link
Collaborator

Not addressing your issue, but FYI.... Use <c-Enter> to close and save (or Escape to close without saving). You can delete rules by tabbing onto the little "x" and hitting enter.

@mrmr1993
Copy link
Contributor

it might be necessary to do some changes.

This is a bug with Firefox not resizing the pop-up properly, because they've put it in a frame to insulate it from the title bar/back button. This doesn't happen if the bar isn't present (ie. Vimium is in not in the dropdown menu) and happens to all other WebExtensions that are put into the menu.

It's definitely worth going and voting for the FF issue (under details), so that the Proton team give it higher priory.

I don't think we should do anything on our side.

@bartlibert
Copy link
Author

bartlibert commented Sep 28, 2017 via email

@mrmr1993
Copy link
Contributor

mrmr1993 commented Sep 28, 2017

I'm not sure they will modify the behaviour

I'm not sure that they can leave it how it is: most extensions' pop-ups will work incorrectly from their double-chevron menu. There is also no clear (or reliable) workaround. This makes it a bug with that menu, not with the individual extensions.

Naturally, the advice most extensions will give -- and the advice I'm going to give here -- is that that menu is broken, and that you shouldn't use Vimium with it at present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants