Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link hints doesn't show hints for many elements on web.whatsapp.com #1978

Closed
meain opened this issue Feb 4, 2016 · 14 comments
Closed

Link hints doesn't show hints for many elements on web.whatsapp.com #1978

meain opened this issue Feb 4, 2016 · 14 comments

Comments

@meain
Copy link

meain commented Feb 4, 2016

Whatsapp.

Unable to enter into a chat using the command 'f', only some links are shown, none of chats though.
Cannot exit out of the bottom textfield in the chat using 'Esc' key

@BlitzKraft
Copy link

I noticed that too. Not only on whatsapp, but on some websites, js links are not reachable using the 'f' key.

@Sanmoo
Copy link

Sanmoo commented Mar 11, 2016

is there any workaround for getting rid of having to use the mouse in these cases?

@smblott-github
Copy link
Collaborator

There are two things causing this...

  1. The element has a tabindex of -1, which we're excluding for some reason.
  2. Nevertheless - and unfortunately - if we remove the condition above and "simulate click" the element, then it doesn't seem to respond anyway.

#1859 doesn't seem to find the clickable element either.

@mrmr1993
Copy link
Contributor

The element has a tabindex of -1, which we're excluding for some reason.

Specifically, we're excluding it because it doesn't make an element respond to clicks, whereas a non-negative tabindex does.

I'm at work so I can't check, but are there any non-site-specific features that distinguish the clickable elements from the others?

@smblott-github
Copy link
Collaborator

are there any non-site-specific features that distinguish the clickable elements from the others?

Looks like they're using React, but you better look yourself.

@donotnoot
Copy link

I know this is an old issue, but it's still happening. Is there anything that can be done other than not using whatsapp web?

@AjayBrahmakshatriya
Copy link

The only thing that I found to work is pressing twice instead of from the input box. The first tab takes the cursor to the chat search box and the second one takes it to the window where there is a list of all chats. All the commands work there.

@hrideshmg
Copy link

The same problem exists 7 years after this issue was discovered, looks like Ajay's workaround doesnt work anymore either.

@haridsv
Copy link

haridsv commented Sep 9, 2022

One workaround to avoid using mouse is to use browser find to find the chat and then pressing <Enter>.

@anders2D
Copy link

of course @haridsv, i going to share the steps:

1.- if you are in a chat box, then use tab key either you only go to the next step
2- Use vimium key "f" to know what letter we can use to go to search box
3- select the key
4- write down the name
5- press enter

READY

@Vaisakhkm2625
Copy link

of course @haridsv, i going to share the steps:

1.- if you are in a chat box, then use tab key either you only go to the next step 2- Use vimium key "f" to know what letter we can use to go to search box 3- select the key 4- write down the name 5- press enter

READY

This is a nice work around... but it would have been awesome if that could be fixed...

@Enzodtz
Copy link

Enzodtz commented Dec 7, 2023

Hi, is the tabindex problem still what is causing this issue?

If I run:

document.querySelectorAll('*').forEach(function(el) {
    if (el.tabIndex < 0) {
        el.tabIndex = 0; // or any number
    }
});

In the console, f still doesn't bring any chats.

Maybe this has to be ran before vimium loads the page content?

My idea would be to write a custom adblock filter to remove those properties that conflict with the extension. Should be something easy, but I'd just need to know what are those.

Thank you

@astr0n0mer
Copy link

The right solution at this point is to use WhatsApp Web's shortcut (Cmd + K) to search and open chats

Press ? on web.whatsapp.com (when logged in) to open the shortcuts table

Screenshot 2024-01-06 at 5 06 20 PM

@philc philc changed the title Issue in https://web.whatsapp.com/ Link hints doesn't show hints for many elements on web.whatsapp.com Jan 13, 2024
@philc
Copy link
Owner

philc commented Jan 13, 2024

Great discussion everyone.

@Enzodtz I checked whether the -1 tab index check is what is preventing many of the links from showing, and it's not. The rows in the list of chats are failing to be detected as links for some deeper reason, which I didn't fully investigate.

While web.whatsapp.com is a popular page, I'm going to close this issue because @astr0n0mer's workaround (use Cmd-K on Mac) is a good solution for this particular issue, and I don't think there's much that can easily be done to make this intricate webapp work better with Vimium. If anyone discovers some changes which can significantly improve Vimium's UX on this site, feel free to reopen this.

Related: WhatsApp also has a desktop app (Mac and PC) which works well. This is what I use rather than visiting the website.

@philc philc closed this as completed Jan 13, 2024
@philc philc closed this as not planned Won't fix, can't repro, duplicate, stale Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests