Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Term suggestion shows error popup #2

Open
buske opened this issue Nov 4, 2019 · 4 comments
Open

Term suggestion shows error popup #2

buske opened this issue Nov 4, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@buske
Copy link
Member

buske commented Nov 4, 2019

The term suggestion is broken because of the lack of a configurable terminology server.

When a terminology server is not present, terms should just be added as plaintext, rather than throwing an error.

@buske buske added bug Something isn't working good first issue Good for newcomers and removed good first issue Good for newcomers labels Nov 4, 2019
@dconlan
Copy link
Collaborator

dconlan commented Nov 9, 2019

alternative sources of terminology
https://clinicaltables.nlm.nih.gov/
https://bioportal.bioontology.org/
FHIR based server like https://ontoserver.csiro.au/

@AlgyTaylor
Copy link
Contributor

AlgyTaylor commented Jul 27, 2021

I may have capacity to look at this bug in the near future - please let me know if this has any particular requirements from your part :)

@shermanlo77
Copy link
Contributor

Does the fork https://github.com/aehrc/open-pedigree address this? New disorders can be added with their changes, awesome stuff! Perhaps we could ask @dconlan for a pull request or incorporate the changes here

@dconlan
Copy link
Collaborator

dconlan commented Jul 1, 2022

I am working on a a pull request with my changes for terminology fetching. I'm not happy with the forced inclusion of the FHIR specific 'system' which goes along with the code. In the FHIR world, a codeable concept needs a system and a code, where the system tells you the code system the code is from. My GA4GH FHIR format pull included an object specifically for letting the converter know what systems to use, which seemed like a better solution then forcing the code that does the webservice call to fetch the codes to know about a system when its only relevant if they are doing a query on a fhir terminology server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

4 participants