Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forks #196

Open
sabas opened this issue Mar 14, 2023 · 8 comments
Open

Forks #196

sabas opened this issue Mar 14, 2023 · 8 comments

Comments

@sabas
Copy link

sabas commented Mar 14, 2023

Hello, I just wanted to ping the recent forks and see if all the contributions can be merged back to this original repository or moved to a single fork..
@BathoryPeter @wgirhad @itamair
@phayes

What do you think?

@wgirhad
Copy link

wgirhad commented Mar 14, 2023

One of the goals of my fork is to merge the contributions from all these other forks. Next I'd refactor the codebase to support the currently supported PHP versions and the latest PHPUnit. And then try to submit back to @phayes (if he's still interested in this project of course).
Actually I didn't try to reach all the authors like you did, but I do fully support your idea.

Thanks for the initiative @sabas

@sabas
Copy link
Author

sabas commented Mar 16, 2023

@wgirhad thanks to you, I downloaded your fork via Packagist in the meantime.
I hope that we can get to a single fork in case, the one you based on was restructured to be PSR complaint so that's a good start!

@sabas
Copy link
Author

sabas commented Mar 16, 2023

I found also this library https://github.com/mjaschen/phpgeo
which has different functions for calculations but doesn't have the adapters which geophp have

@wgirhad
Copy link

wgirhad commented Mar 16, 2023

It seem very well documented and actively developed, but in my use case I really need the OpenGIS implementation, because I have a lib that applies a lossy compression on LineStrings (It's still lacking proper documentation though).

With geoPHP I can serialize it back to geoJSON and/or persist it back into a relational database.

@sabas
Copy link
Author

sabas commented Mar 16, 2023

@wgirhad I was looking at OpenGIS compatibility as well as I have data from a sql server and output to geojson, perhaps we could discuss an approach by email? I sent you one few days ago :)

@itamair
Copy link

itamair commented Mar 16, 2023

thanks ... this looks a nice ideal scenario, but not confident so easily accomplishable, because the all dependencies generated by this original library and all his forks.
For what concerns my point of view, as official maintainer of the Drupal geofield module (with thousands of adoptions, along with its dependant geofield map and leaflet) the following are still true:

  • https://github.com/phayes looks totally inactive on this repo since long time (years);
  • this https://github.com/phayes/geoPHP repo is now not compatible with PHP 8+ version creating blocking issues with new Drupal 10 version, that depends on it (@see this for reference: https://www.drupal.org/project/geofield/issues/3294152);
  • because of the above I needed to fork this and create this parallel repo of mine: https://packagist.org/packages/itamair/geophp where to just extend its compatibility to PHP 8+, and quickly merge most important existing/valuable MRs requests pending here. That shortly reached a lot of adoptions (probably a lot of Drupal Geofield users also) ...
  • for skipping the creation of that new fork of mine, I also previously tested other more solid forks (that adopt src PSR complaint library), such as funiq/geophp one, but that clearly broke Drupal geofield (and its dependent modules) compatibility.
    So I gave up, at the moment, as it would require not trivial effort to refactor & align all of them ... and redeploy brand new dependant releases.

@sabas
Copy link
Author

sabas commented Mar 16, 2023

@itamair What are the functions you need?

I found also this abandoned library and refactored because it had the SimpleFeatures specification (two tests are failing and I didn't succeed in understanding why currently)
https://github.com/pdeffendol/geophp

https://github.com/sabas/GeograPHP

I mostly need to do some geometry operations (distances) and output geojson.
So probably I will add as dependencies mjaschen/phpgeo and https://github.com/jmikola/geojson

@acorncom
Copy link

I've been using https://github.com/Yermo/geoPHPwithFeatures on a project as well that handles features and has some tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants