Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong use of Pharo Announcer #432

Open
tinchodias opened this issue Jan 31, 2024 · 1 comment
Open

Wrong use of Pharo Announcer #432

tinchodias opened this issue Jan 31, 2024 · 1 comment

Comments

@tinchodias
Copy link
Collaborator

The Announcer in Pharo deprecated when:do:, in favor of when:do:for:.

The Bloc event dispatcher uses BlHandlerAnnouncerRegistry which uses an Announcer. And it wrongly skips the the Announcer deprecation in BlHandlerAnnouncerRegistry>>#add:

Additionally, we should evaluate if it's worth having BlHandlerArrayRegistry as an alternative to BlHandlerAnnouncerRegistry, if it's not used. Maybe it was an experiment but the BlHandlerAnnouncerRegistry prevailed.
@tinchodias
Copy link
Collaborator Author

For the record, #499 is slightly related to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tinchodias