Clean up openInNewSpace, openInSpace, showSpace:, etc.

[tinchodias]

I propose to deprecate this method I added to BlElement (if I remember well):

openInNewSpace
	"Add self to a new BlSpace and show it. Answer such space."
	
	| aSpace |
	aSpace := BlSpace new.
	aSpace root addChild: self.
	aSpace show.
	^ aSpace

In favor of:

openInSpace
	"Add self to a new BlSpace and show it. Answer such space."
	| sp |
	sp := self inSpace.
	sp show.
	^ sp

inSpace
	"Add self to a new BlSpace. Answer such space."
	| sp |
	sp := BlSpace new.
	sp root addChild: self.
	^ sp

It can be the opposite, too. But no reason to have both.

[tinchodias]

Additionally, we can rename to showInSpace or showInNewSpace, since that's the term used in the API of BlSpace.

[plantec]

showInSpace and inSpace are ok for me.
thanks

[tinchodias]

@Ducasse what do you think?

[Ducasse]

Trying to get smart :)
When reading openInSpace I was expecting an argument (the space).
If I understand correctly you want to have

• place an child in a space
• open the space.

Now why would we need place child in space because we have addChild:
so this is only when we need to create a space. So the new in the name seems important to me.

So may be we should name them
inNewSpace and openInNewSpace like that we know that they work together.

[tinchodias]

Thanks... But do you prefer openInNewSpace over showInNewSpace?
I think the second since BlSpace has #show, not #open.

[tinchodias]

Bahhh, we can also discuss if "show" is the good term... BlSpace has show, hide and close.

I've just discovered that after "hide", then "show" doesn't work :-/

s := BlSpace new.
s show.
s hide.
s show.

• SDL host: doesn't show it after hide.
• Morphic host: error on hide.

---

Reported here: #434

[tinchodias]

Let's include in the fix for this issue this (unsent) method in BlElement:

showSpace: aSpace
	self hasParent
		ifTrue: [ self parent showSpace: aSpace ]
		ifFalse: [
			self isAttachedToSceneGraph
				ifTrue: [ self space showSpace: aSpace ]
				ifFalse: [ aSpace show ] ]

[tinchodias]

Additional input for the discussion:

First. There are separate testing methods for the concepts of being visible and being opened:

s := BlSpace new.
{ s isOpened. s isVisible }. "#(false false)"
s show.
{ s isOpened. s isVisible }. "#(true true)"
s hide.
{ s isOpened. s isVisible }. "#(true false)"

Second. The comment of BlSpace>>show is "Open me in a window and show it to the user", and it only sends openSpace: to its universe, which sends openSpaceSynchronously:, which:

• sends becomeVisible to the space.
• adds the space to a list so that it will receive pulse on new system events.