-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: create_single_dose_dataset() example creates duplicates #2426
Comments
Hi @jeffreyad do you have time to look into and respond to this issue? |
@bms63 sure, I'll take a look |
Hi @tuiaj thanks for adding the issue. I had not noticed that before. I don't think it affects the final I think you are correct that the Congrats on your first issue! |
Yes - I can try! |
@tuiaj Thanks! Feel free to reach out with any questions you have. |
Hi @tuiaj any update on this? |
@jeffreyad I think they are not around right now - they were trying to do the dummy issue but went AFK. do you mind taking this on or we can ask others on the team? |
@bms63 sure I can take it |
* #2426 Update NFRLT to reduce duplicates * Update vignettes/pk_adnca.Rmd Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com> --------- Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> Co-authored-by: Edoardo Mancini <53403957+manciniedoardo@users.noreply.github.com>
Please select a category the issue is focused on?
Other
Let us know where something needs a refresh or put your idea here!
Was trying out the ADPPK Template but found that the
create_single_dose_dataset()
under the "Expand Dosing Records" section was creating duplicates within the variable NFRLT.which gives:
It seems the duplicates happen for the day of individual visits. Like during the process of unnesting each visit to a dose day/unit, it calculates the visit day twice rather than moving on.
Unsure if this is an actual coding/workflow issue or just specific to the example. In the previous step, "Get Dosing Information" - it creates the original
NFRLT
variable byNFRLT = 24 * (VISITDY - 1)
. ThisNFRLT
is then used in the create_single_dose_dataset() to create the nominal time where the duplicates occur. In the other examples, I couldn't find this occuring.However, when I reformatted the ex data before the
create_single_dose_dataset()
to have the first visitVISITDY
be equal to 0 without altering any of the other visits, it allowed the logic of the function to proceed as intended.There is still duplicates in this reformatted example due to the misalignment of the
VISITDY
and the actual days between visits. I have the derived days between the first visit 2013-07-19 and last visit 2014-01-07 as 172 days ( 24.57 weeks) not the 168 listed. See attached excel for my visual breakdown: example_doseSchedule.xlsxOverall, unsure how specific this problem is to the example data set (or my handling of it), or if it is something else. I am happy to help out wherever I can, but I am very new (this is my first issue on Github!)
The text was updated successfully, but these errors were encountered: