Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using the unified example apply to convert_dtc_to_dt() as necessary and figure out removal of global environment as well #2424

Closed
Tracked by #2369
zdz2101 opened this issue May 1, 2024 · 0 comments · Fixed by #2448
Closed
Tracked by #2369

Using the unified example apply to convert_dtc_to_dt() as necessary and figure out removal of global environment as well #2424

zdz2101 opened this issue May 1, 2024 · 0 comments · Fixed by #2448
Assignees
@zdz2101

Comments

@zdz2101
Copy link
Collaborator

zdz2101 commented May 1, 2024 •
edited

From #2400 , use the unifed input objects and apply to convert_dtc_to_dt() while also making sure our global environment stays empty/clean by the end of the testsuite
@zdz2101 zdz2101 mentioned this issue May 1, 2024
Open
16 tasks
@zdz2101 zdz2101 changed the title cleanup convert_dtc_to_dt() Using the unified example apply to convert_dtc_to_dt() as necessary and figure out removal of global environment as well May 1, 2024
@zdz2101 zdz2101 self-assigned this May 1, 2024
@zdz2101 zdz2101 linked a pull request May 28, 2024 that will close this issue
Closes #2424 cleanup convert_dtc_to_dtm by using unified example #2448
Merged
15 tasks
bms63 added a commit that referenced this issue May 30, 2024
@zdz2101 @bms63
Closes #2424 cleanup convert_dtc_to_dtm by using unified example (#2448)
572d99d 
* address the removal of the unified example

* use input example and rm object so it doesn't stay

* styler/lintr

* update news

* Update NEWS.md

Co-authored-by: Ben Straub <ben.x.straub@gsk.com>

* missed one function

---------

Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zdz2101 zdz2101

Labels
None yet
Projects
admiral (sdtm/adam, dev, ci, template, core)
Status: Archive
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #2424 cleanup convert_dtc_to_dtm by using unified example pharmaverse/admiral
1 participant
@zdz2101