-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General Issue: Improve messaging in derive_extreme_event()
#2405
Labels
Comments
Apologies, referenced this issue in a PR by mistake! |
jeffreyad
pushed a commit
that referenced
this issue
May 30, 2024
15 tasks
jeffreyad
pushed a commit
that referenced
this issue
Jun 3, 2024
jeffreyad
pushed a commit
that referenced
this issue
Jun 4, 2024
jeffreyad
pushed a commit
that referenced
this issue
Jun 4, 2024
bms63
pushed a commit
that referenced
this issue
Jun 4, 2024
#2454) * #2405 update messaging for duplicates in derive_extreme_event() * #2405 update for lint * Update R/derive_extreme_event.R Co-authored-by: Stefan Bundfuss <80953585+bundfussr@users.noreply.github.com> * #2405 update cnd_type to check_type * #2405 update tests * Update R/derive_extreme_event.R Co-authored-by: Stefan Bundfuss <80953585+bundfussr@users.noreply.github.com> * #2405 add check_type = "none" to filter_extreme() * #2405 update filter_joined() --------- Co-authored-by: Jeffrey Dickinson <dickinson.jeffrey@gene.com> Co-authored-by: Stefan Bundfuss <80953585+bundfussr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background Information
The messaging in
derive_extreme_event()
should be improved. Consider the following example.It creates the following warnings.
That's not user-friendly because
Definition of Done
The function is updated such that the issues mentioned above are resolved.
The text was updated successfully, but these errors were encountered: