-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General Issue: Ensure argument name is correct in error messages #2404
Comments
There might be more functions then just |
Hi @ProfessorP-beep do you still have time to work on this? We have a release on June 3rd and want to have this updated. |
Hey @bms63, Yea, was just reviewing again to start on it today since I have time to pick these back up this week. |
@bms63 quick question, are the custom error messages written in each assert_()* function or kept in another script? I was going over the other related tickets as well. |
they are in the admiraldev repo |
Do I need to be added as a contributor there as well? Just pulled it and working on the assert error. Thanks. |
YEs please list yourself as a contributor. I hope you stay around!! If there is no activity for a while, we bump folks down to acknowledgements https://github.com/pharmaverse/admiral?tab=readme-ov-file#acknowledgments |
Background Information
For
assert_*()
calls where the argument is quoted (usingenexpr()
) thearg_name
argument should be specified to display the correct argument name. For example init should be "Argument
filter_add
must be a filter condition" instead of "Argumentenexpr(filter_add)
must be a filter condition".Definition of Done
All error messages display the correct argument name.
The text was updated successfully, but these errors were encountered: