Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2372 tracking and addressing changes from admiraldev #2373

Closed

Conversation

bms63
Copy link
Collaborator

@bms63 bms63 commented Mar 13, 2024

Tracking changes happening in admiraldev

@bms63 bms63 linked an issue Mar 13, 2024 that may be closed by this pull request
5 tasks
@zdz2101
Copy link
Collaborator

zdz2101 commented Mar 13, 2024

@pharmaverse/admiral I noticed the CI/CD error that appears here in the dummy PR's, is this a known bug?

@bms63
Copy link
Collaborator Author

bms63 commented Mar 13, 2024

@pharmaverse/admiral I noticed the CI/CD error that appears here in the dummy PR's, is this a known bug?

What error appear?

@zdz2101
Copy link
Collaborator

zdz2101 commented Mar 13, 2024

Looks like something related to derive_param_exposure()
image

@zdz2101
Copy link
Collaborator

zdz2101 commented Mar 13, 2024

perhaps related to the changes being made on admiraldev ?

@bms63
Copy link
Collaborator Author

bms63 commented Mar 13, 2024

Looks like something related to derive_param_exposure() image

ummm....I guess I was wrong about admiraldev not being picked up anymore in our CI actions without turning on Remotes. Something must be happening with staged.dependencies still??

@bms63
Copy link
Collaborator Author

bms63 commented Mar 13, 2024

@millerg23 @ddsjoberg so I guess staged.dependencies is still engaged as this step happens before it gets to Remotes. Seems to be impacting other PRs
image

@millerg23
Copy link
Collaborator

@bms63 do you want me to update the unit tests, based on whats been updated so far in admiraldev (main branch). Or wait until all the ERROR messaging updates are complete in admiraldev??

@bms63
Copy link
Collaborator Author

bms63 commented Mar 13, 2024

@bms63 do you want me to update the unit tests, based on whats been updated so far in admiraldev (main branch). Or wait until all the ERROR messaging updates are complete in admiraldev??

Maybe we should wait until everything is completed in admiraldev - might be nice to start collecting in #2372 all the updates needed.

maybe folks working on other PRs can just check locally that admiral is still working with CRAN version of admiraldev

@bms63
Copy link
Collaborator Author

bms63 commented Mar 13, 2024

@manciniedoardo any idea what is up with this dummy_study_design.png?

Copy link

github-actions bot commented Mar 13, 2024

Code Coverage

Package Line Rate Health
admiral 98%
Summary 98% (4730 / 4818)

@bms63 bms63 closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General Issue: Tracking updates for admiraldev
3 participants