Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Enable passing additional arguments to get_terms() #2265

Closed
bundfussr opened this issue Nov 30, 2023 · 0 comments · Fixed by #2411
Closed

Feature Request: Enable passing additional arguments to get_terms() #2265

bundfussr opened this issue Nov 30, 2023 · 0 comments · Fixed by #2411
Assignees
@millerg23
Labels
enhancement New feature or request programming

Comments

@bundfussr
Copy link
Collaborator

Feature Idea

The basket_select() object should be updated such that additional arguments can be specified. These arguments should be passed to the get_terms() function. This is required if the dictionary version is not sufficient to select a basket. For example, Roche uses in addition "Implementation Version" and "Implementation Status".

Relevant Input

No response

Relevant Output

No response

Reproducible Example/Pseudo Code

No response
@bundfussr bundfussr added enhancement New feature or request programming future Issue to be implemented after release labels Nov 30, 2023
@bms63 bms63 removed the future Issue to be implemented after release label Apr 17, 2024
@millerg23 millerg23 linked a pull request Apr 17, 2024 that will close this issue
Closes #2265 update basket_select function #2411
Merged
15 tasks
bms63 added a commit that referenced this issue May 23, 2024
@millerg23 @bms63 @bundfussr
Closes #2265 update basket_select function (#2411)
0655873 
* 2265 update basket_select function

* 2265 fix STYLER issue

* Update NEWS.md

Co-authored-by: Ben Straub <ben.x.straub@gsk.com>

* 2265 fix STYLER

* Update R/create_query_data.R for cli_abort

Co-authored-by: Stefan Bundfuss <80953585+bundfussr@users.noreply.github.com>

* 2265 update header for ... argument

* 2265 update unit test

* 2265 update format.select_basket

* 2265 fix STYLER

* 2265 address LINTR ERROR

---------

Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
Co-authored-by: Stefan Bundfuss <80953585+bundfussr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@millerg23 millerg23

Labels
enhancement New feature or request programming
Projects
admiral (sdtm/adam, dev, ci, template, core)
Status: Archive
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #2265 update basket_select function pharmaverse/admiral
3 participants
@bms63 @millerg23 @bundfussr