No avatar update on image share option

[Nispeon]

I noticed that my card still shows my avatar from last year, while my page on git-stars.com displays my new avatar.

After some fast digging I realized that the user template actually gets the image's url from github thanks to the user's ID:

git-stars/templates/user/show.html.twig

Line 47 in 24abc4e

<img src="https://avatars.githubusercontent.com/u/{{ user.githubId }}?v=4&s=150" alt="{{ user.username }}" class="{% if user.organization == false %}rounded-circle{% endif %} user-picture-main">

While the image generated to share our stats used an avatar saved locally on the server:

git-stars/src/Controller/ShareController.php

Line 81 in 24abc4e

$imagePath = __DIR__ . '/../../public/avatars/' . $user->getGithubId() . '.jpg';

Maybe a system to replace the images after a while would be a nice addition, or maybe we should fetch and store the user's avatar when the user is updated.

I wanted your feedback before digging into it 😄