The parameter PWP__SIGNUP_EMAIL_REGEXP does not work

[CorentinDeBoisset]

🐛 Bug Report

When setting the environment variable PWP__SIGNUP_EMAIL_REGEXP, it has no effect. When searching in the code for the usage of the string "regexp" the only matches are the declaration of the parameter but it does not seems to be used anywhere.

🔬 How To Reproduce

Steps to reproduce the behavior:

1. Configure pwpush with PWP__DISABLE_SIGNUPS=false and PWP__SIGNUP_EMAIL_REGEXP="\A[^@\s]+@domain\.tld\z"
2. Create an account for another domain, gmail.com for instance
3. Receive a sign-up email instead of an error

Code sample

N/A

Environment

Where are you running/using Password Pusher?

• pwpush.com
• Docker Image
  • pwpush
  • custom image
• Heroku
• Digital Ocean
• Microsoft Azure
• Google Cloud
• AWS
• Source Code
• Other (please specify)

If applicable, what version of Password Pusher? 1.35.0

Screenshots

N/A

📈 Expected behavior

There should be an error when trying to sign up using an email that does not match the regexp.

📎 Additional context

N/A

[github-actions]

Hello @CorentinDeBoisset, thanks for contributing to the Password Pusher community! We will respond as soon as possible.

[pglombardo]

Hi @CorentinDeBoisset - The regexp is applied here. It plugs into Devise which is the authentication system in use.

I just retested it myself and it works here locally:

Are you sure you applied the environment variable correctly?

Let me know - I can explain in more detail if you like but really the regexp is just passed through into Devise.

[anikwai]

Use single quotation '' for the environment variable works for me. PWP__SIGNUP_EMAIL_REGEXP: '\A[^@\s]+@[^@\s]+\z'

[pglombardo]

That's a good point @anikwai - @CorentinDeBoisset have you tried with single quotes? Are you still having this issue?

[pglombardo]

Hi @CorentinDeBoisset - let me know if this is still an issue for you. If not, I'll close out this issue soon but you can re-open or file another anytime. I'd be happy to help out.

[riahc3]

I had to do it without quotes at all..... (PWP__SIGNUP_EMAIL_REGEXP)

[pglombardo]

Quotes are required as it's a string that is parsed by the Regexp class.