Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboard buttons don't work on non SSL sites #1667

Open
ddrx1984 opened this issue Nov 28, 2023 · 8 comments
Open

Clipboard buttons don't work on non SSL sites #1667

ddrx1984 opened this issue Nov 28, 2023 · 8 comments
Labels
question self-hosted Applies to self-hosted instances

Comments

@ddrx1984
Copy link

ddrx1984 commented Nov 28, 2023

Hello, I hope you can understand me, I use Google Translate.
I set up the password pusher in Docker and everything worked great.
But unfortunately the "clipboard buttons" don't work, the buttons are like dead without any function and nothing is put on the "clipboard".
copied.
My command for Docker is like this:
docker run --name pwpush1 -d -p "5100:5100"
-e PWP__BRAND__LIGHT_LOGO=/logos/mylogo.png
-e PWP__DEFAULT_LOCALE=de
-v /var/lib/pwpush/logos:/opt/PasswordPusher/public/logos
pglombardo/pwpush:release

Would it be possible to fix the “clipboard copy”?
I have version v1.34.1

also look at the screenshot

button1

Button2

Thank you very much

@pglombardo
Copy link
Owner

Hi @ddrx1984 - the copy buttons won't work unless you are hosting with SSL. #1020 has a bit more information.

Are you hosting in plain HTTP?

@ddrx1984
Copy link
Author

Hi @pglombardo,

yes, exactly internally via IP address http://10.200.10.85:5100. Is there a bug at the moment?? can you fix this?? Thanks

@ddrx1984
Copy link
Author

ddrx1984 commented Nov 29, 2023

good morning @pglombardo,
version v1.34.3 / latest still has the error.

docker run --name pwpush1 -d -p "5100:5100"
-e PWP__BRAND__LIGHT_LOGO=/logos/mylogo.png
-e PWP__DEFAULT_LOCALE=de
-v /var/lib/pwpush/logos:/opt/PasswordPusher/public/logos
pglombardo/pwpush:latest

Can you tell me how long the error would be fixed?
Thank you

@ddrx1984
Copy link
Author

ddrx1984 commented Dec 3, 2023

Hi @pglombardo ,

hi, would the errors with the clipboard be fixed in the latest version?

@pglombardo
Copy link
Owner

Hi @ddrx1984

Can you tell me how long the error would be fixed?

No idea currently. This is a browser security based issue. I might be able to find a work around but I'm not sure when as I often am juggling between this project and my day job. I'll update this issue once I have an update. Unfortunately I don't have an ETA.

hi, would the errors with the clipboard be fixed in the latest version?

No

@ddrx1984
Copy link
Author

ddrx1984 commented Dec 4, 2023

Good morning @pglombardo ,
it's a shame that the bug can't be solved.
But I'm wondering why the "clipboard" button works on the website: https://pwpush.com/?
I'm attaching a screenshot. I get these errors in the developer mode of the Chrome browser when I click this button.

It would be really cool if you could solve this, thanks
3

@pglombardo pglombardo changed the title Clipboard buttons don't work Clipboard buttons don't work on non SSL sites Dec 28, 2023
@pglombardo
Copy link
Owner

Hi @ddrx1984 - just as a late response:

But I'm wondering why the "clipboard" button works on the website: https://pwpush.com/?

pwpush.com com is hosted via https. The bug exists on http sites.

@ddrx1984
Copy link
Author

Hi @ddrx1984 - just as a late response:

But I'm wondering why the "clipboard" button works on the website: https://pwpush.com/?

pwpush.com com is hosted via https. The bug exists on http sites.

Yes, I know that, and that's why I reported it to you. For me it runs locally without https. it would be nice if you could fix this bug. Thanks

@pglombardo pglombardo added the self-hosted Applies to self-hosted instances label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question self-hosted Applies to self-hosted instances
Projects
None yet
Development

No branches or pull requests

2 participants