Add an option to use a custom Favicon

[kayvanaarssen]

Can you make it an option in the config file to use a custom favicon.
Either link to one, or link to a location inside the docker container (mount location)

[pglombardo]

Hi @kayvanaarssen - you can configure the favicons with these settings. Make sure to set the icon_57x57 to something as the customisation is keyed off of that value.

[kayvanaarssen]

Thanks that did the Trick, but I did link it like this:

- type: bind
        source: './custom/favicon'
        target: '/opt/PasswordPusher/app/assets/images/favicon'

Than in the .env i've set the path like: /opt/PasswordPusher/app/assets/images/favicon/favicon.png

It did not like that...
So for now i've just linked them to our public website to grab the Favicon but is this a bug or am I doing something wrong here?

[pglombardo]

Yeah I should probably add a note about that. This is complexity with the app framework. If you place a file in assets/images, then assets need to be precompiled, fingerprinted and the asset needs to be loaded with asset_path.

We don't do that for custom icons - we just put the raw value on the page so it has to be a fully qualified HTTPS URL.

[kayvanaarssen]

Right, did not know that😉 Not using the pre compile option so that's why it did not work.
Now loading it directly from our website so that's also fine.

[pglombardo]

HI @kayvanaarssen - I'll close this out soon if nothing remains. BTW I saw the other issue you filed - I'll have a closer look at it over the weekend.