Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example for subgraph C_n (page 268, version 3.1.9a) not reproducible #1194

Open
jasperhabicht opened this issue Oct 6, 2022 · 3 comments · May be fixed by #1198
Open

Example for subgraph C_n (page 268, version 3.1.9a) not reproducible #1194

jasperhabicht opened this issue Oct 6, 2022 · 3 comments · May be fixed by #1198
Labels
manual

Comments

@jasperhabicht
Copy link

Version

3.1.9a

Details

The fourth example on page 268 (section 19 "Specifying Graphs", subsection "19.1" Overview) can only be reproduced using the graphs.standard library, but not using the graphs library as the code suggests. There seems to be a mistake in the code example.

The provided code example is:

\usetikzlibrary {graphs}
    \tikz
        \graph [nodes={draw, circle}, clockwise, radius=.75cm, empty nodes, n=8] {
            subgraph C_n [name=inner] <->[shorten <=1pt, shorten >=1pt]
            subgraph C_n [name=outer]
    };

It should be:

\usetikzlibrary {graphs.standard}
    \tikz
        \graph [nodes={draw, circle}, clockwise, radius=.75cm, empty nodes, n=8] {
            subgraph C_n [name=inner] <->[shorten <=1pt, shorten >=1pt]
            subgraph C_n [name=outer]
    };
@jasperhabicht jasperhabicht changed the title Example for subgraph C_n (page 268, 3.1.9a) not reproducable Example for subgraph C_n (page 268, manual for version 3.1.9a) not reproducible Oct 6, 2022
@jasperhabicht jasperhabicht changed the title Example for subgraph C_n (page 268, manual for version 3.1.9a) not reproducible Example for subgraph C_n (page 268, version 3.1.9a) not reproducible Oct 6, 2022
@muzimuzhi
Copy link
Member

duplicate of #971, which was marked as duplicate of the more general #640

@Mo-Gul
Copy link
Contributor

Mo-Gul commented Oct 7, 2022

@muzimuzhi, true, but I think nonetheless this issue should be fixed, because it is quite easy to do.

There are also some other wrong instances left. But they can be found easily. It just needs to be checked if examples containing subgraph have the library graphs.standard listed (at least for the non-Lua parts of the manual). Shall I propose a PR or do you want to do that?

@muzimuzhi
Copy link
Member

Shall I propose a PR or do you want to do that?

@Mo-Gul Please feel free to go ahead.

@muzimuzhi muzimuzhi linked a pull request Oct 8, 2022 that will close this issue
docs: correct/add subgraph preamble comments (fixes #1194) #1198
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
manual
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: correct/add subgraph preamble comments (fixes #1194) Mo-Gul/pgf
3 participants
@muzimuzhi @jasperhabicht @Mo-Gul