Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Replace "service" wording #2325

Closed
udf2457 opened this issue Apr 15, 2024 · 2 comments · Fixed by #2352
Closed

Docs: Replace "service" wording #2325

udf2457 opened this issue Apr 15, 2024 · 2 comments · Fixed by #2352
Assignees
Milestone

Comments

@udf2457
Copy link
Contributor

udf2457 commented Apr 15, 2024

In the docs section 20, "Starting and Stopping", pgbackrest is referred to as a "service".

I would argue that on Linux, the word "service" has quite a specific well-understood meaning, i.e. a daemon.

Meanwhile, my understanding of the docs, is that when you talk about "Stop the pgBackRest services" and "Start the pgBackRest services", what you are really doing is "Disable pgBackRest configuration" and "Enable pgBackRest configuration".

In and itself pgbackrest does nothing unless you manually run it or call it via cron or systemd timers. So it doesn't meet the definition of a "service" IMHO.

@dwsteele dwsteele self-assigned this Apr 18, 2024
@dwsteele
Copy link
Member

Well, pgbackrest does also run as a service, but I see what you are getting at.

But I don't think Disable pgBackRest configuration really describes it either. Really what we are doing here is stopping writes to the repo going forward, but in fact stop will terminate any pgbackrest process that is currently running.

In truth I rather regret this feature. It was written for a particular user use case years ago and just didn't have enough thought put into it. Now it sort of works for certain use cases but I don't think it is effective overall.

@dwsteele dwsteele added this to the 2.52 milestone May 19, 2024
@dwsteele
Copy link
Member

I have updated the start/stop documentation to remove "service" in #2352.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants