Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webrepl missing in ESP8266 port from v3.2.3 #50

Open
iBobik opened this issue Jul 18, 2020 · 1 comment
Open

Webrepl missing in ESP8266 port from v3.2.3 #50

iBobik opened this issue Jul 18, 2020 · 1 comment

Comments

@iBobik
Copy link

iBobik commented Jul 18, 2020

In build firmware for ESP8266 generic board I miss modules webrepl and webrepl_setup. (ImportError)

In v3.2.2 version it is ok, could be related to changes here:

If not the bug has to be introduced somewhere here: v3.2.2...v3.2.3

I use this builder: https://gitlab.com/janpoboril/micropython-docker-build/-/tree/pycopy

@pfalcon
Copy link
Owner

pfalcon commented Jul 18, 2020

Thanks for the report.

The story here would be: I initially was skeptical about "manifest" feature from upstream, IMHO it's just complexity-rising and security-questionable feature, so I kinda skipped it, preferring to use old good modules/ dir with symlinks. However, manifests become more pervasive in upstream, so I have little choice but to follow with their proliferation. (Another choice would be to formally "drop" support for baremetal ports using it, which I'm kinda not ready yet, hoping that baremetal ports maintainers interested in them will surface).

So, for 3.2.3, I went over upstream history, and pulled whatever was missing from "manifest" support code. Thus, that part was indeed touched, and it may have led to some regressions (either not everything was pulled in, or there're conflicts with older code used).

As I mentioned a few times, I concentrate on "finishing" Pycopy, and working on the reference port, the Unix port. If there's interest in running Pycopy on baremetal targets in the meantime, I welcome contributions (like, testing and investigating cases like this). If not, it goes into backlog, and I'll look into it when have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants