Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper resizing support requires sufficiently deep codebase refactors #50

Open
arcivanov opened this issue Jan 30, 2021 · 1 comment
Open
Labels

Comments

@arcivanov
Copy link

This is related to #48 and is demonstrated on top of #49.

After resize in the examples/example_screen_resize.py, the use of arrow controls produces artifacts with dialog components being confused about their locations relative to the dialog.

Example:

2021-01-30.17-51-26.mp4
@pfalcon
Copy link
Owner

pfalcon commented Jan 31, 2021

Thanks for taking care to record video.

Yes, "resizing" support is experimental, and pretty hacked-up for now. There're at least 2 issues:

  1. Resize handling happens via asynchronous signals, and that's problematic and not reliable. Needs to be reworked to just produce a suitable synchronous event instead, like everything else.
  2. As you noticed (and I now remember), drawing setup isn't actually designed with relative coordinates in mind, and needs to be refactored (which is potentially backward incompatible change).

Some time ago I started to look into p.1, which turned out to be a bit of rabit hole due to https://www.python.org/dev/peps/pep-0475/ . It waits in backlog so far.

@pfalcon pfalcon changed the title Resize example produces artifacts Proper resizing support requires sufficiently deep codebase refactors Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants