Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate handling of red and blue color balance #28

Open
wherget opened this issue Jan 16, 2022 · 0 comments
Open

separate handling of red and blue color balance #28

wherget opened this issue Jan 16, 2022 · 0 comments

Comments

@wherget
Copy link

wherget commented Jan 16, 2022

(this is an issue submitted by [vogarth] on the showmewebcam Discord)

Expected Behavior

UVC control WHITE_BALANCE_COMPONENT can affect both V4L2_CID_RED_BALANCE and V4L2_CID_BLUE_BALANCE independently.

Current Behavior

(my analysis from reading code, not [vogarth]'s).
V4L2_CID_RED_BALANCE and V4L2_CID_BLUE_BALANCE are both set to the value of V4L2_CID_RED_BALANCE

This affects both master and feat/new-code.

Possible Solution

AFAICS the UVC control sends two bytes (red/blue separately) as control value, and v4l2_set_ctrl only receives a single int, which it sets for both channels. There should probably be some additional handling for handling multi-byte UVC controls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant