Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][FEATURE] Navigation to proc of child processes enabled #113

Closed
wants to merge 2 commits into from
Closed

[WIP][FEATURE] Navigation to proc of child processes enabled #113

wants to merge 2 commits into from

Conversation

roysti10
Copy link
Member

@roysti10 roysti10 commented May 15, 2021 •
edited

Description

Navigation to the child processes is enabled in the case of grofer proc -p <pid>. Keybinding used is Enter.

Fixes #100

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have read the contribution guidelines and followed it as far as possible.
  • I have performed a self-review of my own code (if applicable)
  • I have commented my code, particularly in hard-to-understand areas (if applicable)
  • I have run go fmt on my code (reference)
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • Any dependent and pending changes have been merged and published

Additional Info

  • Causes Error when trying to exit with two or more child process navigation. Error might have occurred due to the recursive call in line 183

Screenshot from 2021-04-13 10-24-56

  • Need to enable the feature for allProcs.go i,e grofer proc

@roysti10
Bug fixes
b64c3b1 
   * Formatting
@MadhavJivrajani
Copy link
Member

@lucasace I remember you asking a few questions on slack, if those questions are still unanswered, can you please state them here again and provide a little bit of context so that we can help you out with this PR?

@MadhavJivrajani
Copy link
Member

Closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gituser143 Gituser143 Awaiting requested review from Gituser143 Gituser143 is a code owner

@MadhavJivrajani MadhavJivrajani Awaiting requested review from MadhavJivrajani MadhavJivrajani will be requested when the pull request is marked ready for review MadhavJivrajani is a code owner

@metonymic-smokey metonymic-smokey Awaiting requested review from metonymic-smokey metonymic-smokey will be requested when the pull request is marked ready for review metonymic-smokey is a code owner

@Samyak2 Samyak2 Awaiting requested review from Samyak2 Samyak2 will be requested when the pull request is marked ready for review Samyak2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] Add keybind to navigate to child process in grofer proc
2 participants
@roysti10 @MadhavJivrajani