Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Velocity to 2.0 #68

Open
valtterip opened this issue Nov 2, 2017 · 1 comment
Open

Update Velocity to 2.0 #68

valtterip opened this issue Nov 2, 2017 · 1 comment

Comments

@valtterip
Copy link

It does indeed look like the Velocity team has released their septennial update https://velocity.apache.org/news.html

The 2.0 should probably be taken into this project as well?

Thanks!

@toyg
Copy link

toyg commented Feb 8, 2019

This is actually a security issue now, because 1.7 is vulnerable due to the dependency on commons-collections 3.2.1.

It looks like there is a slight change required in VelocityTemplateEngine.java to make it work with Velocity 2. Because all context keys are String now, the line:

Map<?, ?> modelMap = (Map<?, ?>) model;

has to become something like:

Map<String, Object> modelMap = (Map<String, Object>) model;

I'll send a pull request as soon as I get the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants