Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideas #17

Open
5 of 8 tasks
ali-master opened this issue Sep 8, 2020 · 15 comments
Open
5 of 8 tasks

Ideas #17

ali-master opened this issue Sep 8, 2020 · 15 comments
Assignees
Labels
enhancement New feature or request

Comments

@ali-master
Copy link
Member

ali-master commented Sep 8, 2020

Is your feature request related to a problem? No

Describe the solution you'd like
New ideas which we can add to the PersianTools:

  • Calculate bill information by Bill id and Payment id.
  • Get bank information via IBAN number.
  • Replace spaces by half-space in Persian texts.
  • Write a great typescript documentation.
  • Design and implement a website for the demo by React and Github-pages.
  • Implement the Persian-tools for the Vue.js.
  • Implement the Persian-tools for the Angular.js.
  • Implement the Persian-tools for the Angular 2+.

This list will be completed day by day.

@moh3n9595
Copy link
Member

I think 9825504 implemented your idea that is named "Replace spaces by half-space in Persian texts."
Please check this out and update your idea's list if needed.

@ali-master
Copy link
Member Author

Persian-tools2 v1.2.4 published. Thanks, Mohsen Jan.

@ali-master ali-master added the enhancement New feature or request label Sep 30, 2020
@ali-master ali-master pinned this issue Sep 30, 2020
@ali-master
Copy link
Member Author

@all-contributors please add @ali-master for infrastructure, tests and code

@allcontributors
Copy link
Contributor

@ali-master

I've put up a pull request to add @ali-master! 🎉

@mediv0
Copy link
Member

mediv0 commented Feb 26, 2021

hi,
What is your proposal to Implement this package with Vue.js?
I can work on RP if you want

@ali-master
Copy link
Member Author

Well well well

Hi @mediv0
What a good news, If you are ready, I send you an invitation to the Persian-Tools Oganization and create a repo and write codes.

@mediv0
Copy link
Member

mediv0 commented Feb 26, 2021

Well well well

Hi @mediv0
What a good news, If you are ready, I send you an invitation to the Persian-Tools Oganization and create a repo and write codes.

not a problem, I am rdy

@pshaddel
Copy link
Contributor

pshaddel commented Apr 23, 2021

Hi @ali-master
I've seen that in this repo we are not using git hooks for commit and commit message(also I saw that we are running linter and prettier in the pipeline).
What I have in mind is using a git hook tool like husky to check the code before being able to make a pull request and commit the code.

Also one other thing that would be useful is using a commit message convention to keep all the commit messages structure the same. I think Conventional Commit is a well-known candidate and we can create a commit message hook to validate this commit message. There are two options to validate commit messages: 1-commitlint 2- commitizen.

Looking foreward to hearing your opinion. Let me know if I can start creating the PR to make these two changes(git hooks, commit validation)

@ali-master
Copy link
Member Author

Hi @ali-master
I've seen that in this repo we are not using git hooks for commit and commit message(also I saw that we are running linter and prettier in the pipeline).
What I have in mind is using a git hook tool like husky to check the code before being able to make a pull request and commit the code.

Also one other thing that would be useful is using a commit message convention to keep all the commit messages structure the same. I think Conventional Commit is a well-known candidate and we can create a commit message hook to validate this commit message. There are two options to validate commit messages: 1-commitlint 2- commitizen.

Looking foreward to hearing your opinion. Let me know if I can start creating the PR to make these two changes(git hooks, commit validation)

I'm in, let's start.

@Mahdi-Farahani
Copy link

@ali-master
hi how is it going ?
i can Design and implement a website for the demo by React and Github-pages.
document for Usage and show demo from each functions work.
Can I start????

@ali-master
Copy link
Member Author

@ali-master
hi how is it going ?
i can Design and implement a website for the demo by React and Github-pages.
document for Usage and show demo from each functions work.
Can I start????

Hi @Mahdi-Farahani Jan,

I appreciate it if you help us, I would like to have a short meeting with you as soon as you have free time. Please an email to ali_4286[at]live[dot]com

@Mahdi-Farahani
Copy link

@ali-master
ok we can talk together with skype
this is my skype id = mahdifrhn91
please send me msg in skype .
thanks .

@mohammadizanloo55
Copy link

Hi, I think we need to have a function in this library to verify the names of Iranian cities from a string.
example :
validateIranCity("تهران") // return true
validateIranCity("تست") // return false

@ShahriarKh
Copy link

Wanna move this thread to discussions?

@ali-master
Copy link
Member Author

Good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants