Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnecessary dependency to uvicorn #25

Open
WisniewskiP opened this issue Sep 5, 2023 · 1 comment
Open

unnecessary dependency to uvicorn #25

WisniewskiP opened this issue Sep 5, 2023 · 1 comment
Assignees

Comments

@WisniewskiP
Copy link

I think uvicorn could be removed from requirements as it add unneeded dependencies on client side.

fastapi package can be used with uvicorn but doesn't add explicit dependency to it.

$ pip show fastapi
Name: fastapi
Version: 0.95.1
Summary: FastAPI framework, high performance, easy to learn, fast to code, ready for production
Home-page:
Author:
Author-email: Sebastián Ramírez <tiangolo@gmail.com>
License:
Location: c:\users\pawelwisniewski\executionplatform\ep\venv-3.10\lib\site-packages
Requires: pydantic, starlette
@orweis
Copy link
Contributor

orweis commented Sep 6, 2023

Hi @WisniewskiP - I think you're right - though I'll ask for someone on the team to quickly review to be on the safe side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants