Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to View Function Drilldowns Aggregated Runs #42

Open
JohanTan opened this issue Aug 5, 2013 · 4 comments
Open

Ability to View Function Drilldowns Aggregated Runs #42

JohanTan opened this issue Aug 5, 2013 · 4 comments

Comments

@JohanTan
Copy link

JohanTan commented Aug 5, 2013

It is a feature that the oldest XHProf GUI has and is very useful. So far the url.php page is pretty useful. But it would be nicer to have the view of aggregated time and memory use from either all runs in the same day for a particular url, or the ones that user selected. Would that be possible?

@markstory
Copy link
Member

You can currentlylimit the url view by date range. I'll have to look at how the original aggregated drilldown was done. I missed seeing that feature whn looking at the other project.

@anho
Copy link
Contributor

anho commented Aug 6, 2013

This is definitely a must-have. When using ajax-based apps I'm currently unable to have a look at the page load as a whole as it does gather data from different paths. Reusing the view used for selecting a run for comparison would be a good start.

@markstory
Copy link
Member

It couldn't simply be a re-use of existing code though. As a number of features can't be re-used:

  • Symbol links can't be generated as multiple runs could have the same symbol called.
  • Callgraphs can't be generated as there could be N unique requests.

If this is a must-have it will either need some more clarification around how it is supposed to work. I'll take a look at how the original xhprof implemented this, but I don't simply re-using what we have will work well.

@anho
Copy link
Contributor

anho commented Aug 7, 2013

I wasn't talking about re-using the code, just the view to select the runs that should be aggregated. And an accumulated callgraph is what I'm really keen about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants