Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on coding style and enforce mostly with PHPCS #299

Open
Krinkle opened this issue Jul 17, 2020 · 4 comments
Open

Decide on coding style and enforce mostly with PHPCS #299

Krinkle opened this issue Jul 17, 2020 · 4 comments

Comments

@Krinkle
Copy link
Contributor

Krinkle commented Jul 17, 2020

Less burden on reviewers, less guess work on the contributing person (ergo me). Also automation in supporting IDEs with automatic fixing/adapting as needed.

It looks like the current code looks mostly like PSR-2. Is that intentional?

(Extracted out of #16)

@markstory
Copy link
Member

It looks like the current code looks mostly like PSR-2. Is that intentional?

Yes and no. I think PSR2 is a good base target to get to. I never got around to fully updating the existing code though.

@glensc
Copy link
Contributor

glensc commented Oct 28, 2020

@markstory perhaps remove Sticker CI integration? it seems broken and no support.

It's marked CI job as failed, example: #363

but can't retrieve any details why.

the link from PR leads to https://stickler-ci.com/repositories/156-perftools-xhgui but that says "bummer, The requested address /repositories/156-perftools-xhgui was not found."

The "login" on the page leads to https://stickler-ci.com/github/authorize, and redirects back to the same page, and even still shows "login" even I've logged in.

I've contacted their support, and they have not even responded over several months.

can you remove the integration? as I think I don't even have permission to remove the integration.

@markstory
Copy link
Member

@glensc Oddly enough I run stickler, and never got any support emails. I can look into what is not working with the login flow. There are build logs and results in the Github checks views though.

@glensc
Copy link
Contributor

glensc commented Oct 30, 2020

@markstory ok, I can see output via GitHub actions, so I guess can leave as is then.

The other link gave an error and I contacted their support, but the ☎️ is dead

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants