missing labels problem fixed #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patco96
suggested changes
Nov 18, 2022
There was a problem hiding this comment.
Even though we don't have a PR template yet, maybe the PR description could show a bit more what the original behavior was and how it should be now.
Also, why remove the id_field? Maybe a small comment before this code section would be helpful for others:
dataset = next(iter(dataset_query))
_, _, headers = load_csv_with_headers(dataset.csv_path)
headers.remove("_idx")
headers.remove(str(dataset.id_field))This is what happens for me when I run vectory demo now:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of possible labels was an empty list. Now it is a list with the headers of the CSV associated with the selected dataset.