Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle around the geocoded place #157

Open
ilyankou opened this issue Mar 22, 2017 · 1 comment
Open

Circle around the geocoded place #157

ilyankou opened this issue Mar 22, 2017 · 1 comment

Comments

@ilyankou
Copy link

I developed a feature to draw a circle with a specified radius around the geocoded place upon searching for @JackDougherty's leaflet-maps-with-google-sheets, and I am wondering if it's something that can be added to the main repo. Its main purpose is to be able to easily detect markers that lie within a certain distance from the place.

screen shot 2017-03-22 at 19 24 53
screen shot 2017-03-22 at 19 25 06

It requires two additional parameters to geocoder: circle (true/false), and circleRadius (number, in miles).

screen shot 2017-03-22 at 19 32 45

@louh
Copy link
Contributor

louh commented Mar 28, 2017

Hi @ilyankou, thanks for the suggestion.

I think you've developed a really interesting application with the geocoder, but I'm not certain that it has much utility for other geocoder users outside of your use case. We want to keep our plugin scoped fairly tightly to Mapzen Search functionality, and the circle might confuse users into thinking it might mean something about search accuracy. (See, for example, the accuracy indicator from the locatecontrol plugin, which looks very similar.)

Perhaps it would be best to showcase the circle as a demo, instead? We keep a directory of examples which includes examples of how the geocoder plugin can be augmented with more advanced integrations and additional features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants