Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for docker compose v2 #316

Closed
wants to merge 1 commit into from
Closed

support for docker compose v2 #316

wants to merge 1 commit into from

Conversation

arnesetzer
Copy link

@arnesetzer arnesetzer commented May 15, 2023 •
edited

馃憢 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.

Here's the reason for this change 馃殌

Should fix #315

Here's how others can test the changes 馃憖

  • Execute every pelias command on a system with only docker compose v2 support and check if it crashes.
  • Execute every pelias command on a system with only docker compose v1 support and check if it crashes.

This PR adds support for docker compose v2 with the fallback to v1, if v2 is not installed or can not be found (checks with exit codes the docker compose version returns).

@arnesetzer arnesetzer changed the title support for compose v2 support for docker compose v2 May 15, 2023
@arnesetzer arnesetzer mentioned this pull request May 26, 2023
Open
@missinglink missinglink mentioned this pull request Jun 1, 2023
Merged
@arnesetzer
Copy link
Author

Duplicate of #303

@arnesetzer arnesetzer closed this Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No support for docker compose v2
1 participant
@arnesetzer